Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(radio): disable animations when using NoopAnimationsModule #11296

Merged
merged 1 commit into from
May 15, 2018

Conversation

crisbeto
Copy link
Member

Disables the CSS-based animations in the radio buttons when the NoopAnimationsModule is used.

Disables the CSS-based animations in the radio buttons when the `NoopAnimationsModule` is used.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 12, 2018
Copy link
Contributor

@tinayuangao tinayuangao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release and removed pr: needs review labels May 13, 2018
@josephperrott
Copy link
Member

Addresses #10590

@tinayuangao tinayuangao merged commit af78b97 into angular:master May 15, 2018
tinayuangao pushed a commit that referenced this pull request May 15, 2018
Disables the CSS-based animations in the radio buttons when the `NoopAnimationsModule` is used.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 8, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants