fix(sidenav): scrollable instance not exposed when explicitly specifying content element #11517
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ing content element * Fixes the `MatSidenavContainer.scrollable` being undefined if the consumer has set the `mat-sidenav-content` themselves. The issue comes from the fact that we only query for scrollables inside the drawer's own view, but not inside the projected content. * Fixes the example in the sidenav docs accessing the scrollable too early. Fixes angular#10884. BREAKING CHANGE: the constructor signature of the `MatDrawerContent` and `MatSidenavContent` has changed.
googlebot
added
the
cla: yes
mmalerba
approved these changes
May 29, 2018
mmalerba
added
pr: lgtm
action: merge
mmalerba
pushed a commit
that referenced
this pull request
Jul 29, 2018
…ing content element (#11706) This is a resubmit of #11517 which got in by accident. * Fixes the `MatSidenavContainer.scrollable` being undefined if the consumer has set the `mat-sidenav-content` themselves. The issue comes from the fact that we only query for scrollables inside the drawer's own view, but not inside the projected content. * Fixes the example in the sidenav docs accessing the scrollable too early. Fixes #10884. BREAKING CHANGE: the constructor signature of the `MatDrawerContent` and `MatSidenavContent` has changed.
|
@andrewseguin @crisbeto @mmalerba Could you please merge and release this as part of 7? The next window of opportunity is 8 after that, and I fear it will be quite long time to that. Thank you for the consideration! |
|
@crisbeto want to just do the |
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
MatSidenavContainer.scrollablebeing undefined if the consumer has set themat-sidenav-contentthemselves. The issue comes from the fact that we only query for scrollables inside the drawer's own view, but not inside the projected content.Fixes #10884.
BREAKING CHANGE: the constructor signature of the
MatDrawerContentandMatSidenavContenthas changed.