fix(select,autocomplete): unable to set custom id on mat-option #11573
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
|
@crisbeto could you rebase? |
jelbourn
added
pr: needs rebase
and removed
action: merge
crisbeto
force-pushed
the
11572/option-id
branch
from
16450d6 to
1b6d09b
Compare
|
Rebased. |
crisbeto
added
action: merge
josephperrott
removed
the
action: merge
|
@crisbeto It looks like this one has some CI failures |
crisbeto
force-pushed
the
11572/option-id
branch
from
1b6d09b to
dd89fd7
Compare
Fixes consumers not being allowed to set their own id on a `mat-option`. Fixes angular#11572.
crisbeto
force-pushed
the
11572/option-id
branch
from
dd89fd7 to
a24329f
Compare
|
The compilation error is sorted out now. |
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
Fixes consumers not being allowed to set their own id on a `mat-option`. Fixes #11572.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes consumers not being allowed to set their own id on a
mat-option.Fixes #11572.