Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(stepper): handle removing a step before the current one #11813

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

crisbeto
Copy link
Member

Fixes an error that is thrown by the stepper if a step before the current one is removed.

Fixes #11791.

Fixes an error that is thrown by the stepper if a step before the current one is removed.

Fixes angular#11791.
@crisbeto crisbeto requested a review from mmalerba as a code owner June 17, 2018 10:14
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jun 17, 2018
@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker target: patch This PR is targeted for the next patch release labels Jun 17, 2018
@jelbourn jelbourn merged commit 82b35d0 into angular:master Aug 23, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
Fixes an error that is thrown by the stepper if a step before the current one is removed.

Fixes #11791.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

*ngIf on a mat-step breaks the stepper if the expression becomes false from a later step
4 participants