fix(overlay): clear duplicate overlay container coming in from the server #11940
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
josephperrott
added
pr: lgtm
action: merge
Closed
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Jul 25, 2018
…erver Fixes the case where the user might get multiple live announcer elements, if they're coming in from a server-side-rendered page. Along the same lines as angular#11940.
|
I'd love to see some movement on this as it's currently blocking me. |
|
Hey, are there any updates on this PR? This PR is crucial for my project :) |
crisbeto
force-pushed
the
11817/overlay-container-cleanup
branch
from
bb4a1ff to
5c2081c
Compare
crisbeto
force-pushed
the
11817/overlay-container-cleanup
branch
from
5c2081c to
cc4470b
Compare
crisbeto
force-pushed
the
11817/overlay-container-cleanup
branch
from
cc4470b to
ee18407
Compare
…rver When coming from a server-side-rendered page, we may end up in a situation where there are multiple overlay containers on the page with stale overlays in them. These changes clear all old overlay containers before creating a new one. Relates to angular#11817.
crisbeto
force-pushed
the
11817/overlay-container-cleanup
branch
from
ee18407 to
2d1a48f
Compare
|
Looks like there were a handful of unit test failures inside Google on this change. I'll see if we're able to debug them |
jelbourn
added
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When coming from a server-side-rendered page, we may end up in a situation where there are multiple overlay containers on the page with stale overlays in them. These changes clear all old overlay containers before creating a new one.
Relates to #11817.