Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(autofill): avoid firing unnecessary event on initial render of input #12116

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix(autofill): avoid firing unnecessary event on initial render of input #12116

merged 1 commit into from
Jul 18, 2018

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Jul 9, 2018

No description provided.

@mmalerba mmalerba added perf This issue is related to performance G This is is related to a Google internal issue regression This issue is related to a regression labels Jul 9, 2018
@mmalerba mmalerba requested a review from jelbourn July 9, 2018 17:49
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 9, 2018
@mmalerba mmalerba requested a review from crisbeto July 9, 2018 17:50
@mmalerba mmalerba added the P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful label Jul 9, 2018
jelbourn
jelbourn approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 9, 2018
@ngbot
Copy link

ngbot bot commented Jul 9, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    failure status "ci/circleci: build" is failing
    pending status "continuous-integration/travis-ci/pr" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

crisbeto
crisbeto approved these changes Jul 9, 2018
View reviewed changes
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

src/cdk/text-field/autofill.ts
// we fire off events.
if (event.animationName === 'cdk-text-field-autofill-start' &&
!element.classList.contains(cssClass)) {
element.classList.add(cssClass);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You're repeating element.classList in a few places here. Consider moving it out into a variable.

@josephperrott josephperrott added the target: patch This PR is targeted for the next patch release label Jul 9, 2018
@josephperrott
Copy link
Member

@mmalerba can you rebase and push again to fix the circleci failure?

@josephperrott josephperrott removed the action: merge The PR is ready for merge by the caretaker label Jul 18, 2018
@josephperrott josephperrott merged commit c2fc3f4 into angular:master Jul 18, 2018
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@mmalerba @josephperrott
fix(autofill): avoid firing unnecessary event on initial render of in…
1fb1fab 
…put (#12116)
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@mmalerba @josephperrott
fix(autofill): avoid firing unnecessary event on initial render of in…
1cbc038 
…put (#12116)
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@crisbeto crisbeto crisbeto approved these changes

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

@crisbeto crisbeto

Labels
cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful perf This issue is related to performance regression This issue is related to a regression target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@mmalerba @josephperrott @jelbourn @crisbeto @googlebot