Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(menu): collapse empty menu panel #12211

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix(menu): collapse empty menu panel #12211

merged 1 commit into from
Jul 18, 2018

Conversation

crisbeto
Copy link
Member

Changes up the selector for the menu panel, in order to have it collapse when it's empty. This avoids weird blank panels being left behind when mat-menu instances are reused between triggers.

For reference:
demo

@crisbeto
fix(menu): collapse empty menu panel
e41059b 
Changes up the selector for the menu panel, in order to have it collapse when it's empty. This avoids weird blank panels being left behind when `mat-menu` instances are reused between triggers.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 14, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 14, 2018
jelbourn
jelbourn approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 16, 2018
@josephperrott josephperrott merged commit b23cecd into angular:master Jul 18, 2018
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@crisbeto @josephperrott
fix(menu): collapse empty menu panel (#12211)
db33773
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@crisbeto @josephperrott
fix(menu): collapse empty menu panel (#12211)
aed3993
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

Assignees

@jelbourn jelbourn

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @josephperrott