Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(tabs): enable keyboard wrapping and mark disabled tabs #12218

Merged
merged 1 commit into from
Jul 18, 2018
Merged

fix(tabs): enable keyboard wrapping and mark disabled tabs #12218

merged 1 commit into from
Jul 18, 2018

Conversation

crisbeto
Copy link
Member

  • According to the a11y guidelines, the tab arrow keys should wrap when they reach the end of the list. These changes enable wrapping.
  • Adds aria-disabled to disabled tabs.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) target: patch This PR is targeted for the next patch release labels Jul 15, 2018
@crisbeto crisbeto requested a review from andrewseguin as a code owner July 15, 2018 11:21
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 15, 2018
@crisbeto
fix(tabs): enable keyboard wrapping and mark disabled tabs
9ef8191 
* According to [the a11y guidelines](https://www.w3.org/TR/wai-aria-practices-1.1/#tabpanel), the tab arrow keys should wrap when they reach the end of the list. These changes enable wrapping.
* Adds `aria-disabled` to disabled tabs.
jelbourn
jelbourn approved these changes Jul 16, 2018
View reviewed changes
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Jul 16, 2018
@josephperrott josephperrott merged commit 7f8fd9f into angular:master Jul 18, 2018
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@crisbeto @josephperrott
fix(tabs): enable keyboard wrapping and mark disabled tabs (#12218)
671eff2
josephperrott pushed a commit that referenced this pull request Jul 18, 2018
@crisbeto @josephperrott
fix(tabs): enable keyboard wrapping and mark disabled tabs (#12218)
0e03aae
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jelbourn jelbourn jelbourn approved these changes

@andrewseguin andrewseguin Awaiting requested review from andrewseguin

Assignees

@jelbourn jelbourn

Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@crisbeto @jelbourn @googlebot @josephperrott