Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tabs] Tabs active indicator not responsive #1231

Closed
svi3c opened this issue Sep 12, 2016 · 1 comment · Fixed by #3877
Closed

[Tabs] Tabs active indicator not responsive #1231

svi3c opened this issue Sep 12, 2016 · 1 comment · Fixed by #3877
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@svi3c
Copy link
Contributor

svi3c commented Sep 12, 2016

Bug, feature request, or proposal:

When resizing the VP, The tab active indicator size and position is not recalculated.
This is causing for problems if you want to have the tabs span accross the full width via setting flex-grow: 1 for example. I currently have

:host /deep/ .md-tab-label {
  flex: 1;
  min-width: 120px !important;
}

in my component styles.

This represents the fixed tabs type of the md tabs specs: https://material.google.com/components/tabs.html#tabs-types-of-tabs

What is the expected behavior?

The position and size should be recalculated when resizing the viewport.

What is the current behavior?

When You resize the Viewport, the length and position of the active indicator stays the same.

What are the steps to reproduce?

Visit http://plnkr.co/edit/tFkzdaw9ejYBpo3OGnKC?p=preview and resize the VP.

What is the use-case or motivation for changing an existing behavior?

Static tabs are part of the material design spec.

Which versions of Angular, Material, OS, browsers are affected?

All, I think. Tested with aplha 7 and alpha 8.

@svi3c svi3c changed the title bug(tabs) Tabs active indicator not responsive Tabs active indicator not responsive Sep 14, 2016
@andrewseguin andrewseguin self-assigned this Nov 3, 2016
@andrewseguin andrewseguin changed the title Tabs active indicator not responsive [Tabs] Tabs active indicator not responsive Nov 16, 2016
@andrewseguin andrewseguin added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 16, 2016
@crisbeto crisbeto added the has pr label Apr 2, 2017
crisbeto added a commit to crisbeto/material2 that referenced this issue Apr 2, 2017
* Recalculates the ink bar position, as well as the pagination, if the viewport size changes.
* Adds a missing test on the `tab-nav-bar` regarding repositioning on direction changes.

Fixes angular#3845.
Fixes angular#3044.
Fixes angular#2518.
Fixes angular#1231.
kara pushed a commit that referenced this issue Apr 21, 2017
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants