Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): remove aria-owns attribute while closed #12333

Merged
merged 1 commit into from
Jul 24, 2018

Conversation

crisbeto
Copy link
Member

Removes the aria-owns attribute from the autocomplete trigger while the panel is closed.

Fixes #12332.

Removes the `aria-owns` attribute from the autocomplete trigger while the panel is closed.

Fixes angular#12332.
@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Jul 23, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jul 23, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jelbourn jelbourn added pr: lgtm Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker labels Jul 23, 2018
@mmalerba mmalerba merged commit f0a0ab1 into angular:master Jul 24, 2018
mmalerba pushed a commit that referenced this pull request Jul 30, 2018
Removes the `aria-owns` attribute from the autocomplete trigger while the panel is closed.

Fixes #12332.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

mat-autocomplete causes invalid aria-owns value
4 participants