Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Animation does not work in versions 6.4.0 and 6.4.1 when MatProgressBar is set to buffer mode. #12338

Closed
oncatalog opened this issue Jul 24, 2018 · 1 comment · Fixed by #12350
Closed

Animation does not work in versions 6.4.0 and 6.4.1 when MatProgressBar is set to buffer mode. #12338

oncatalog opened this issue Jul 24, 2018 · 1 comment · Fixed by #12350
Assignees
@crisbeto
Labels
P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression

Comments

@oncatalog
Copy link

oncatalog commented Jul 24, 2018 •
edited
Loading

Bug, feature request, or proposal:

Bug

What is the expected behavior?

Animation should work when MatProgressBar is set to buffer mode.

What is the current behavior?

Animation does not work in versions 6.4.0 and 6.4.1 when MatProgressBar is set to buffer mode in the named outlet.

What are the steps to reproduce?

In normal cases, it operates normally without errors. However, I used a named outlet like 'http://localhost:3200/blog/work/(header:post//main:post/test/compose)'. Also, when I use MatProgressBar in buffer mode in the component specified in the 'header' and 'main' named outlet, an error occurs that can not be animated.
Even if you use MatProgressBar in a named outlet, 6.3.3 will work normally without any errors.

In 6.4.0, 6.4.1, we have found that url is used in the fill attribute of . I think this is the cause of the error.
@crisbeto crisbeto self-assigned this Jul 24, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 24, 2018
@crisbeto
fix(progress-bar): query animation not working inside routes with nam…
cc62d92 
…ed outlets

This is something that was introduced by angular#12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes angular#12338.
@crisbeto crisbeto mentioned this issue Jul 24, 2018
Merged
@crisbeto crisbeto added P2 The issue is important to a large percentage of users, with a workaround has pr regression This issue is related to a regression labels Jul 24, 2018
crisbeto added a commit to crisbeto/material2 that referenced this issue Jul 24, 2018
@crisbeto
fix(progress-bar): query animation not working inside routes with nam…
e21c70f 
…ed outlets

This is something that was introduced by angular#12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes angular#12338.
mmalerba pushed a commit that referenced this issue Jul 26, 2018
@crisbeto @mmalerba
fix(progress-bar): query animation not working inside routes with nam…
b9c0d85 
…ed outlets (#12350)

This is something that was introduced by #12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes #12338.
mmalerba pushed a commit that referenced this issue Jul 30, 2018
@crisbeto @mmalerba
fix(progress-bar): query animation not working inside routes with nam…
0c526d3 
…ed outlets (#12350)

This is something that was introduced by #12014. Because we didn't have quotes around the URL in the `fill` value, the reference could become invalid if the user is on a route with a named outlet, which contains parentheses in its URL.

Fixes #12338.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees

@crisbeto crisbeto

Labels
P2 The issue is important to a large percentage of users, with a workaround regression This issue is related to a regression
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix(progress-bar): query animation not working inside routes with named outlets crisbeto/material2
2 participants
@crisbeto @oncatalog