fix(table): error if row definition is on an ng-container #12462
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
reviewed
Jul 31, 2018
src/lib/table/table.spec.ts
Outdated
| </ng-container> | ||
|
|
||
| <mat-header-row *matHeaderRowDef="columnsToRender"></mat-header-row> | ||
| <ng-container *matRowDef="let row; columns: columnsToRender"></ng-container> |
There was a problem hiding this comment.
What even gets rendered when you do this?
There was a problem hiding this comment.
I omitted the empty mat-row to keep the test more concise, but if I have it renders as it's supposed to. It's based on this: https://stackblitz.com/edit/angular-5vkqs1?file=app/table-pagination-example.html. I'll re-add the mat-row to keep it closer to the real scenario.
Fixes the table throwing an error if the row definitions are on an `ng-container`. Fixes angular#12460.
crisbeto
force-pushed
the
12460/sticky-styler-error
branch
from
30a7dc5 to
a46f5a1
Compare
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
Fixes the table throwing an error if the row definitions are on an `ng-container`. Fixes #12460.
jelbourn
pushed a commit
that referenced
this pull request
Aug 7, 2018
Fixes the table throwing an error if the row definitions are on an `ng-container`. Fixes #12460.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes the table throwing an error if the row definitions are on an
ng-container.Fixes #12460.