feat(autocomplete): align with 2018 material design spec #12570
Conversation
googlebot
added
the
cla: yes
| @@ -579,6 +579,13 @@ export class MatAutocompleteTrigger implements ControlValueAccessor, OnDestroy { | |||
| {originX: 'start', originY: 'top', overlayX: 'start', overlayY: 'bottom'} | |||
| ]); | |||
|
|
|||
| this._positionStrategy.positionChanges.subscribe(({connectionPair}) => { | |||
There was a problem hiding this comment.
Add a comment here like...
// The overlay edge connected to the trigger has squared corners, while
// the opposite end has rounded corners. We apply a css class to swap the
// border-radius based on the overlay position.Alternatively, since this seems to be a common pattern, what do you think of adding a panelClass property to ConnectedPosition (to be applied when that position is used)?
There was a problem hiding this comment.
I've included the comment and I've left a note for myself to add a panelClass to the ConnectedPosition.
Aligns the autocomplete with the most-recent Material design spec. These changes are based on the menu designs since there isn't any concrete design for an autocomplete. Note that the changes only cover the adjustments to the autocomplete panel. The design changes for the options will come together with `mat-select` since the two components both use `mat-option`.
crisbeto
force-pushed
the
autocomplete-new-spec
branch
from
88566a8 to
a82ffe8
Compare
crisbeto
changed the title
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
jelbourn
added
the
P2
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Aligns the autocomplete with the most-recent Material design spec. These changes are based on the menu designs since there isn't any concrete design for an autocomplete. Note that the changes only cover the adjustments to the autocomplete panel. The design changes for the options will come together with
mat-selectsince the two components both usemat-option.