Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Spinner causes endless cycle of scrollbar growth and shrinking #1259

Closed
RoxKilly opened this issue Sep 18, 2016 · 1 comment · Fixed by #1742
Closed

Spinner causes endless cycle of scrollbar growth and shrinking #1259

RoxKilly opened this issue Sep 18, 2016 · 1 comment · Fixed by #1742
Assignees
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent

Comments

@RoxKilly
Copy link

RoxKilly commented Sep 18, 2016

Bug, feature request, or proposal:

Bug

What is the expected behavior?

If the spinner fits in the browser window, it should not cause scrollbars

What is the current behavior?

The spinner (or the styles related to its animation) cause the browser (Firefox 48) to go through an endless cycle of growing and shrinking scrollbars. Adding core.css and overlay.css makes no difference.

What are the steps to reproduce?

Open this Plunkr and look at the scrollbars.

What is the use-case or motivation for changing an existing behavior?

Bad UI experience. Plus having the browser constantly recalculate spacing and animate scrollbars is a waste of resources.

Which versions of Angular, Material, OS, browsers are affected?

Angular 2 rc-6, Material 2 alpha 8-1, Firefox 48 on Windows

Anything else we should know?

One possible way to deal with this is to place the spinner in a div that hides its overlfow:

<div style="overflow:hidden">
    <md-spinner></md-spinner>
</div>

See this Plunkr

@jelbourn jelbourn added the P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent label Nov 4, 2016
@jelbourn jelbourn changed the title [spinner @alpha 8-1] Spin causes endless cycle of scrollbar growth and shrinking Spinner causes endless cycle of scrollbar growth and shrinking Nov 4, 2016
@crisbeto crisbeto added the has pr label Nov 5, 2016
crisbeto added a commit to crisbeto/material2 that referenced this issue Nov 5, 2016
Fixes the progress spinner expanding and shrinking it's scrollable parent.

Fixes angular#1259.
jelbourn pushed a commit that referenced this issue Nov 8, 2016
Fixes the progress spinner expanding and shrinking it's scrollable parent.

Fixes #1259.
rolandjitsu pushed a commit to rolandjitsu/material2 that referenced this issue Nov 10, 2016
Fixes the progress spinner expanding and shrinking it's scrollable parent.

Fixes angular#1259.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 5, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants