feat(overlay): add the ability to set a panelClass based on the current connected position #12631
Conversation
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
connected-position-panel-class
branch
from
f848cc4 to
f205299
Compare
| @@ -1799,6 +1799,110 @@ describe('FlexibleConnectedPositionStrategy', () => { | |||
| }); | |||
| }); | |||
|
|
|||
| describe('panel classes', () => { | |||
There was a problem hiding this comment.
Add a test for not removing an existing css class on the element?
crisbeto
force-pushed
the
connected-position-panel-class
branch
from
f205299 to
6d89fe4
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
@crisbeto is the failure on circle ci real? |
…nt connected position Adds a property on the `ConnectedPosition` to allow the consumer to set a class on the overlay pane, depending on which position is currently active.
crisbeto
force-pushed
the
connected-position-panel-class
branch
from
6d89fe4 to
cc4155e
Compare
|
Looks like it was a real failure @jelbourn, but it's fixed now. |
Takes advantage of the API introduced in angular#12631 to add a class to the panel automatically, based on its position.
Takes advantage of the API introduced in #12631 to add a class to the panel automatically, based on its position.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Adds a property on the
ConnectedPositionto allow the consumer to set a class on the overlay pane, depending on which position is currently active.