-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(schematics): do not allow specifying native view encapsulation #12632
fix(schematics): do not allow specifying native view encapsulation #12632
Conversation
I don't know if this is a good idea; our theming doesn't work with native shadow DOM. |
The option is just setting the I see that we should probably not support this. If we don't want to go that way, even though it's kind of bad for consistency, we should also consider removing the |
No longer allows developers to specify the `--viewEncapsulation Native` when creating components through the Angular Material schematics. Since Angular Material does not work properly with Native / ShadowDom view encapsulation, we should not support these as valid schematic options.
9f21d06
to
ae05678
Compare
@jelbourn Addressed what we discussed in the standup. Though we do not have a good way of throwing an error because we need to handle the possible values through the schema. Otherwise, tools that show the available options for a schematic (e.g. AngularConsole) will incorrectly display |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
No longer allows developers to specify the
--viewEncapsulation Native
when creating components through the Angular Material schematics. Since Angular Material does not work properly with Native / ShadowDom view encapsulation, we should not support these as valid schematic options.