fix(form-field): remove outline gap for empty labels #12637
Conversation
googlebot
added
the
cla: yes
src/lib/form-field/form-field.ts
Outdated
| labelWidth += child.offsetWidth; | ||
| } | ||
|
|
||
| this._outlineGapStart = labelStart - containerStart - outlineGapPadding; | ||
| this._outlineGapWidth = labelWidth * floatingLabelScale + outlineGapPadding * 2; |
There was a problem hiding this comment.
should probably also add logic to make the _outlineGapWidth 0 if the labelWidth is 0
crisbeto
force-pushed
the
form-field-blank-label
branch
from
a166009 to
d81e88e
Compare
mmalerba
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
|
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
Removes the outline gap in outlined form fields, if the label element doesn't have any content.
crisbeto
force-pushed
the
form-field-blank-label
branch
from
d81e88e to
b3cb7ab
Compare
Removes the outline gap in outlined form fields, if the label element doesn't have any content.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Removes the outline gap in outlined form fields, if the label element doesn't have any content.
For reference: