-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix(live-announcer): avoid triggering a reflow when reading directive content #12638
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. Technically a breaking change because innerText
and textContent
have a different value in some cases (see here)
I think the cases where the values would be different are pretty rare since you wouldn’t apply the directive on something with complex content. |
True. That's why I wrote that it could be technically a breaking change. Would be probably still worth adding a small note for it to the changelog if we merge it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Hi @crisbeto! This PR has merge conflicts due to recent upstream merges. |
… content Uses `textContent`, instead of `innerText`, to avoid triggering a reflow when reading off the content of the directive element.
9d929d8
to
3b525d6
Compare
… content (#12638) Uses `textContent`, instead of `innerText`, to avoid triggering a reflow when reading off the content of the directive element.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Uses
textContent
, instead ofinnerText
, to avoid triggering a reflow when reading off the content of the directive element.