Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(live-announcer): avoid triggering a reflow when reading directive content #12638

Merged
merged 1 commit into from
Aug 27, 2018

Conversation

crisbeto
Copy link
Member

Uses textContent, instead of innerText, to avoid triggering a reflow when reading off the content of the directive element.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 11, 2018
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 11, 2018
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Technically a breaking change because innerText and textContent have a different value in some cases (see here)

@crisbeto
Copy link
Member Author

I think the cases where the values would be different are pretty rare since you wouldn’t apply the directive on something with complex content.

@devversion
Copy link
Member

True. That's why I wrote that it could be technically a breaking change. Would be probably still worth adding a small note for it to the changelog if we merge it.

@devversion devversion added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 11, 2018
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ngbot
Copy link

ngbot bot commented Aug 21, 2018

Hi @crisbeto! This PR has merge conflicts due to recent upstream merges.
Please help to unblock it by resolving these conflicts. Thanks!

… content

Uses `textContent`, instead of `innerText`, to avoid triggering a reflow when reading off the content of the directive element.
@crisbeto crisbeto force-pushed the live-announcer-reflow branch from 9d929d8 to 3b525d6 Compare August 25, 2018 17:08
@jelbourn jelbourn merged commit 040f9db into angular:master Aug 27, 2018
jelbourn pushed a commit that referenced this pull request Aug 29, 2018
… content (#12638)

Uses `textContent`, instead of `innerText`, to avoid triggering a reflow when reading off the content of the directive element.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants