fix(list): improved image scaling in avatar #12660
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
jelbourn
added
pr: lgtm
action: merge
devversion
approved these changes
Aug 13, 2018
Improves the scaling for list avatar images that aren't exact squares. Fixes angular#8131.
crisbeto
force-pushed
the
8131/list-avatar-scaling
branch
from
e47f84b to
8cd8604
Compare
crisbeto
added a commit
to crisbeto/material2
that referenced
this pull request
Aug 26, 2018
Along the same lines as angular#12660. Uses `object-fit: cover` to better scale the avatar image, where available.
jelbourn
pushed a commit
that referenced
this pull request
Aug 26, 2018
Along the same lines as #12660. Uses `object-fit: cover` to better scale the avatar image, where available.
jelbourn
pushed a commit
that referenced
this pull request
Aug 27, 2018
Along the same lines as #12660. Uses `object-fit: cover` to better scale the avatar image, where available.
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
Improves the scaling for list avatar images that aren't exact squares. Fixes #8131.
jelbourn
pushed a commit
that referenced
this pull request
Aug 29, 2018
Along the same lines as #12660. Uses `object-fit: cover` to better scale the avatar image, where available.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Improves the scaling for list avatar images that aren't exact squares.
Fixes #8131.
For reference:
