fix(progress-bar): incorrectly handling current path when using hash location strategy #12713
Conversation
crisbeto
added
P2
googlebot
added
the
cla: yes
src/lib/progress-bar/progress-bar.ts
Outdated
| this._rectangleFillValue = `url('${location ? location.path() : ''}#${this.progressbarId}')`; | ||
| // because named route URLs can contain parentheses (see #12338). Also we don't use | ||
| // `Location` from `@angular/common`, because we can't tell the difference between whether | ||
| // the consumer is using the hash location strategy or not. |
There was a problem hiding this comment.
Couldn't you do the same thing with location.path() from @angular/common's Location?
There was a problem hiding this comment.
That's what it used to do, but AFAIK Angular's location.path will normalize both of these to the same value: /#/foo/bar and /foo/bar.
There was a problem hiding this comment.
Ah, got it. Can you expand the comment with that?
...the consumer is using the hash location strategy or not because it normalizes both
`/#/foo/bar` and `/foo/bar` to the same thing
…location strategy Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`. Fixes angular#12710.
crisbeto
force-pushed
the
12710/progress-bar-hash
branch
from
62b7288 to
a3f5206
Compare
jelbourn
added
pr: lgtm
action: merge
|
I see that you just added the If you want your PR to be merged, it has to pass all the CI checks. If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help. |
…location strategy (#12713) Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the router normalizes the `location.pathname` between the regular strategy and the hash one, whereas we need to use the exact same path as the `window.location`. Fixes #12710.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Fixes the progress bar prefixing the references incorrectly when the consumer is using the router's hash location strategy. The issue comes from the fact that the
Locationnormalizes thelocation.pathnamebetween the regular strategy and the hash one, whereas we need to use the exact same path as thewindow.location.Fixes #12710.