Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(progress-bar): avoid error on SSR if pathname is undefined #12807

Merged
merged 1 commit into from
Aug 23, 2018

Conversation

jelbourn
Copy link
Member

@jelbourn jelbourn commented Aug 23, 2018

@crisbeto this was causing a problem in Google Shopping Express; for some reason pathname was undefined in the SSR environment. I'm not sure why our kitchen-sink test didn't encounter the same thing.

@jelbourn jelbourn added P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful G This is is related to a Google internal issue labels Aug 23, 2018
@jelbourn jelbourn requested a review from crisbeto August 23, 2018 18:33
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 23, 2018
Copy link
Member

@crisbeto crisbeto left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@crisbeto crisbeto added pr: lgtm action: merge The PR is ready for merge by the caretaker labels Aug 23, 2018
@ngbot
Copy link

ngbot bot commented Aug 23, 2018

I see that you just added the pr: merge ready label, but the following checks are still failing:
    failure missing required label: "target: *"
    pending status "continuous-integration/travis-ci/pr" is pending
    pending status "ci/circleci: build" is pending

If you want your PR to be merged, it has to pass all the CI checks.

If you can't get the PR to a green state due to flakes or broken master, please try rebasing to master and/or restarting the CI job. If that fails and you believe that the issue is not due to your change, please contact the caretaker and ask for help.

@crisbeto crisbeto added the target: patch This PR is targeted for the next patch release label Aug 23, 2018
@jelbourn jelbourn merged commit f3af763 into angular:master Aug 23, 2018
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement G This is is related to a Google internal issue P1 Impacts a large percentage of users; if a workaround exists it is partial or overly painful target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants