Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(top-app-bar): migrate toolbar to top-app-bar #13964

Closed
2 of 14 tasks
CaerusKaru opened this issue Nov 3, 2018 · 6 comments
Closed
2 of 14 tasks

feat(top-app-bar): migrate toolbar to top-app-bar #13964

CaerusKaru opened this issue Nov 3, 2018 · 6 comments
Assignees
Labels
area: material/toolbar feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release

Comments

@CaerusKaru
Copy link
Member

CaerusKaru commented Nov 3, 2018

Bug, feature request, or proposal:

feature request

What is the expected behavior?

Toolbar should be migrated to top-bar, there should be no toolbar component

What is the current behavior?

Toolbar, but no top- or bottom-bar

What is the use-case or motivation for changing an existing behavior?

The spec has been updated to not include a toolbar, instead allowing for "App bars", both top- and bottom-.

Is there anything else we should know?

MDC is also doing this, and it is being tracked here

Tasks

  • Scaffold empty classes, assets, demo, build config, etc.
  • Stub existing component API
  • Hook up MDC foundation and adapter
  • Add remaining features on top of MDC implementation
  • Test dark theme
  • Test RTL
  • Test with screen-readers
  • Copy existing unit tests and ensure they all pass
  • Copy existing e2e tests and ensure they all pass (if any)
  • Verify SSR support in universal-app/
  • Verify no size regression
  • Create test harness
  • Create schematics for migration
  • Create user documentation

Additional notes

Breaking changes

Known issues & visual differences

@vivian-hu-zz vivian-hu-zz added feature This issue represents a new feature or feature request rather than a bug or bug fix P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 9, 2018
@jelbourn jelbourn added P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release and removed P3 An issue that is relevant to core functions, but does not impede progress. Important, but not urgent labels Nov 9, 2018
@mhosman

This comment has been minimized.

@Splaktar
Copy link
Member

Splaktar commented Jun 6, 2019

Related: MDC's mdc-top-app-bar

@Splaktar
Copy link
Member

For reference, here's the merged PR for MDC's mdc-top-app-bar.

@mhosman that's a bottom-app-bar rather than top-app-bar. I've opened #16367 to track the creation of a mat-bottom-app-bar.

@Splaktar Splaktar changed the title feat(top-bar): migrate toolbar to top-bar feat(top-bar): migrate toolbar to top-app-bar May 25, 2020
@Splaktar Splaktar changed the title feat(top-bar): migrate toolbar to top-app-bar feat(top-app-bar): migrate toolbar to top-app-bar May 25, 2020
@Splaktar
Copy link
Member

Docs and a demo for the MDC Top App Bar are now available.

@jelbourn
Copy link
Member

Closing this since we don't plan on migrating <mat-toolbar> to match the "appbar" design from 2018+. We may eventually introduce a new appbar component that supersedes toolbar, but we don't have any immediate plans for this.

@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Aug 22, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: material/toolbar feature This issue represents a new feature or feature request rather than a bug or bug fix P4 A relatively minor issue that is not relevant to core functions target: major This PR is targeted for the next major release
Projects
None yet
Development

No branches or pull requests

6 participants