Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(snack-bar): add explicit box-sizing #1413

Merged
merged 1 commit into from
Oct 5, 2016

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Oct 3, 2016

Fixes the snack bar not being readable in the cases where box-sizing: border-box is applied globally.

Fixes #1412.

Note: this can also be fixed by removing the explicit height, however I wasn't sure whether it wasn't there on purpose (e.g. to prevent line wraps).

Fixes the snack bar not being readable in the cases where `box-sizing: border-box` is applied globally.

Fixes angular#1412.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Oct 3, 2016
@fxck
Copy link
Contributor

fxck commented Oct 4, 2016

Removing explicit height messes up alignment. But honestly, box-sizing: border-box should be explicitly set for all of the components and they should be styled with that in mind. Rather than having different box sizing for each component.

@crisbeto
Copy link
Member Author

crisbeto commented Oct 4, 2016

Hopefully this wouldn't be too much of a problem. In Material 1, there's only 2-3 cases total where the box sizing needs to be reset, I don't expect it to be much more for Material 2. This can also be fixed by removing the padding, but then the vertical alignment is a little trickier since it'd have to use line-height which isn't very consistent across browsers.

@jelbourn
Copy link
Member

jelbourn commented Oct 5, 2016

LGTM

@jelbourn jelbourn merged commit 580da74 into angular:master Oct 5, 2016
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

snackbar is unreadable when using border-box: box-sizing
4 participants