fix(MdCheckbox): Cancel spacebar keydown events when component focused #181
Conversation
googlebot
added
cla: yes
| @@ -192,6 +199,15 @@ export class MdCheckbox implements ControlValueAccessor { | |||
| this.toggle(); | |||
| } | |||
|
|
|||
| onFocus(evt: Event) { | |||
| window.addEventListener('keydown', this._focusWindowKeydownHandler); | |||
There was a problem hiding this comment.
There's actually a special syntax for doing this without directly touching window:
host: {
'(window:domEvent)': 'onWindowEvent($event.type)',
'(document:domEvent)': 'onDocumentEvent($event.type)',
'(body:domEvent)': 'onBodyEvent($event.type)'
}So you can do 'window:focus': 'myFocusHandler()'
There was a problem hiding this comment.
ah that's way better. will change.
traviskaufman
force-pushed
the
fix-gh-162
branch
from
4d9c263 to
fcee873
Compare
|
@jelbourn changes made! |
| * from bubbling when the component is focused, which prevents side effects like page scrolling | ||
| * from happening. | ||
| */ | ||
| onWindowKeyDown(evt: KeyboardEvent) { |
There was a problem hiding this comment.
As discussed in chat: just use keydown on the host element since it should only fire when it has focus anyway?
There was a problem hiding this comment.
👍 yeah I think I overthought it. Changed.
This commit ensures that when a checkbox element is focused, spacebar `keydown` events will not bubble up to window, causing side effects like page scrolling. This commit also fixes an issue as part of this change where the component could still be focused even when it was disabled. Finally, some of the test code has been cleaned up and corrected. Fixes angular#162
traviskaufman
force-pushed
the
fix-gh-162
branch
from
fcee873 to
ac84e25
Compare
|
LGTM |
* Adds the `--depth` option when cloning the assets for the docs.
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
This commit ensures that when a checkbox element is focused, spacebar
keydownevents will not bubble up to window, causing side effects likepage scrolling.
This commit also fixes an issue as part of this change where the
component could still be focused even when it was disabled.
Finally, some of the test code has been cleaned up and corrected.
Fixes #162