Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(button-toggle): add option for vertical toggle groups #1936

Merged
merged 2 commits into from
Nov 30, 2016

Conversation

devversion
Copy link
Member

Adds a new input for showing the associated toggles in a group vertically.

Closes #1892.

Adds a new input for showing the associated toggles in a group vertically.

Closes angular#1892.
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Nov 19, 2016
Copy link
Member

@jelbourn jelbourn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM aside from one minor comment

You can apply the merge ready label after making the change

@@ -47,6 +47,7 @@ export class MdButtonToggleChange {
providers: [MD_BUTTON_TOGGLE_GROUP_VALUE_ACCESSOR],
host: {
'role': 'radiogroup',
'[class.md-vertical]': 'vertical'
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's do md-button-toggle-vertical

@devversion devversion force-pushed the feat/button-toggle-vertical branch from 7075e52 to c9194e3 Compare November 29, 2016 15:08
@jelbourn jelbourn added the action: merge The PR is ready for merge by the caretaker label Nov 29, 2016
@tinayuangao tinayuangao merged commit cb0d6fc into angular:master Nov 30, 2016
@devversion devversion deleted the feat/button-toggle-vertical branch November 30, 2016 20:01
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

md-button-toggle-group with vertical aligned md-button-toggle
4 participants