Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat(autocomplete): add fallback positions #2726

Merged
merged 1 commit into from
Jan 25, 2017
Merged

feat(autocomplete): add fallback positions #2726

merged 1 commit into from
Jan 25, 2017

Conversation

kara
Copy link
Contributor

@kara kara commented Jan 19, 2017

r: @jelbourn

Will need rebasing when #2724 and #2723 go in.

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 19, 2017
@kara kara mentioned this pull request Jan 19, 2017
Closed
andrewseguin
andrewseguin approved these changes Jan 23, 2017
View reviewed changes
Copy link
Contributor

@andrewseguin andrewseguin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewseguin andrewseguin added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs cleanup / tests labels Jan 23, 2017
@kara kara merged commit e2e3163 into angular:autocomplete Jan 25, 2017
kara added a commit that referenced this pull request Jan 25, 2017
@kara
feat(autocomplete): add fallback positions (#2726)
0fe8959
kara added a commit to kara/material2 that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add fallback positions (angular#2726)
311622f
kara added a commit to kara/material2 that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add fallback positions (angular#2726)
f260666
kara added a commit that referenced this pull request Feb 3, 2017
@kara
feat(autocomplete): add fallback positions (#2726)
8fc7706
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@andrewseguin andrewseguin andrewseguin approved these changes

@jelbourn jelbourn Awaiting requested review from jelbourn

Assignees

@jelbourn jelbourn

@andrewseguin andrewseguin

Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@kara @andrewseguin @jelbourn @googlebot