Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(slide-toggle): add support for labelPosition #2836

Merged
merged 2 commits into from
Feb 1, 2017

Conversation

devversion
Copy link
Member

  • Adds an option to change the position of the slide-toggle's label.

Closes #2820

@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Jan 27, 2017
* Adds an option to change the position of the slide-toggle's label.

Closes angular#2820
@@ -85,6 +86,9 @@ export class MdSlideToggle implements AfterContentInit, ControlValueAccessor {
/** Used to specify the tabIndex value for the underlying input element. */
@Input() tabIndex: number = 0;

/** Whether the label should appear after or before the checkbox. Defaults to 'after' */
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"checkbox" > "slide-toggle"

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Jan 27, 2017
@jelbourn
Copy link
Member

LGTM

@kara kara merged commit 68a0c90 into angular:master Feb 1, 2017
@devversion devversion deleted the feat/slide-toggle-label-pos branch February 1, 2017 05:58
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Proposal: Allow md-slide-toggle to be aligned start or end
4 participants