-
Notifications
You must be signed in to change notification settings - Fork 6.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: remove deprecated forRoot functions #3539
Conversation
10964c1
to
41fc5ff
Compare
I kicked off the process to remove all of these from Google apps; we can move forward with this PR once that's done. |
@devversion I've successfully removed all use of |
6c72b36
to
555ec8d
Compare
@jelbourn Rebased the PR. Please take a look. |
555ec8d
to
d2bf729
Compare
@jelbourn Is it planned to release this in |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
d2bf729
to
fb4648b
Compare
@devversion I accidentally lied earlier; there were some instances of |
@devversion Okay, I have, at time of this writing, removed all the |
fb4648b
to
ed311c1
Compare
@jelbourn Oh yeah. Done! |
@devversion another |
@jelbourn Yeah, |
@devversion needs rebase |
ed311c1
to
11648e7
Compare
* In beta.2 the `forRoot` calls have been deprecated, and it was stated that those will be removed in the next release (https://goo.gl/2yFPFc)
11648e7
to
11578d8
Compare
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
forRoot
calls have been deprecated, and it was stated that those will be removed in the next release (https://goo.gl/2yFPFc)