feat: remove hard dependency on @angular/http #3792
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
googlebot
added
the
cla: yes
crisbeto
force-pushed
the
2616/icon-dependency
branch
from
6ba6e75
to
ca27e61
Compare
jelbourn
added
pr: lgtm
action: merge
|
Has presubmit failures in Google where people were depending on this to bring in HttpModule |
jelbourn
added
the
presubmit failures
crisbeto
force-pushed
the
2616/icon-dependency
branch
from
ca27e61
to
ce74103
Compare
crisbeto
force-pushed
the
2616/icon-dependency
branch
from
ce74103
to
0324d7e
Compare
mmalerba
removed
the
presubmit failures
|
I fixed the deps in google, should be able to merge now, needs rebase though |
crisbeto
force-pushed
the
2616/icon-dependency
branch
from
0324d7e
to
bc0cbed
Compare
|
Rebased @mmalerba. |
* Makes `@angular/http` an optional dependency since it is only being used by the icon module. An error will be thrown only if the user runs into something that requires the `HttpModule`. * Moves the various icon error classes into `icon-errors.ts`. * Moves the icon registry provider next to the registry itself, instead of in the same file as the icon directive. Fixes angular#2616.
crisbeto
force-pushed
the
2616/icon-dependency
branch
from
bc0cbed
to
e67a658
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@angular/httpan optional dependency since it is only being used by the icon module. An error will be thrown only if the user runs into something that requires theHttpModule.icon-errors.ts.Fixes #2616.