Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(platform): don't shadow window #4622

Merged
merged 1 commit into from
May 17, 2017
Merged

fix(platform): don't shadow window #4622

merged 1 commit into from
May 17, 2017

Conversation

jelbourn
Copy link
Member

No description provided.

@jelbourn jelbourn requested review from devversion and mmalerba May 17, 2017 15:55
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 17, 2017
@mmalerba
Copy link
Contributor

Is this to fix a bug or fix some typescript error? I think declare ... just gets stripped out of the JS output.

@jelbourn
Copy link
Member Author

It was causing a Googler a problem during a migration due to an extern; I like this approach more anyway, rather than aliases window like it was.

@mmalerba mmalerba added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 17, 2017
@mmalerba
Copy link
Contributor

lgtm

devversion
devversion approved these changes May 17, 2017
View reviewed changes
Copy link
Member

@devversion devversion left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It should only cause issues if the file is explicitly imported using the sources. But anyway LGTM

@jelbourn
Copy link
Member Author

In Google everything is indeed consumed directly from sources

@devversion
Copy link
Member

devversion commented May 17, 2017 •
edited
Loading

Ah I see. Then it makes total sense why the issue appears :)

@jelbourn jelbourn merged commit e8ab0da into angular:master May 17, 2017
@jelbourn jelbourn deleted the window-redeclare branch September 13, 2017 04:37
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 7, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@devversion devversion devversion approved these changes

@mmalerba mmalerba Awaiting requested review from mmalerba

Assignees
No one assigned
Labels
action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@jelbourn @mmalerba @devversion @googlebot