Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(autocomplete): restore focus to input when clicking on an option #4702

Merged

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented May 21, 2017

Restores focus to the autocomplete input when an option is clicked, instead of dumping it into the body.

Note: The CI failures seem to be due to an unrelated issue with our build.

Fixes #4645.

@crisbeto crisbeto added Accessibility This issue is related to accessibility (a11y) pr: needs review labels May 21, 2017
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label May 21, 2017
@crisbeto crisbeto changed the title fix(autocomplete): restore focus to input when click on option fix(autocomplete): restore focus to input when clicking on an option May 21, 2017
Copy link
Contributor

@kara kara left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@kara kara removed their assignment May 22, 2017
@kara kara added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels May 22, 2017
Restores focus to the autocomplete input when an option is clicked, instead of dumping it into the body.

Fixes angular#4645.
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Autocomplete dumps focus to body when selecting via mouse
4 participants