feat: add camelCase selectors where they were missing #4901
Conversation
jelbourn
added
in progress
googlebot
added
the
cla: yes
src/lib/list/list.ts
Outdated
| }) | ||
| export class MdListSubheaderCssMatStyler {} | ||
|
|
||
| @Component({ | ||
| moduleId: module.id, | ||
| selector: 'md-list-item, mat-list-item, a[md-list-item], a[mat-list-item]', | ||
| selector: 'md-list-item, mat-list-item, a[md-list-item], a[mat-list-item],' + | ||
| 'a[mdListItem], a[matListItem]', |
There was a problem hiding this comment.
So it looks like we're just doing away with dash-case attrs entirely, even for components? (I'm happy with that, I've wanted it for a while) shouldn't we do button too?
There was a problem hiding this comment.
This one was a mistake, reverted
jelbourn
force-pushed
the
consistent-apis
branch
3 times, most recently
from
aa90297
to
39b9add
Compare
jelbourn
added
pr: needs review
and removed
in progress
|
Officially for review now; I will update the tests and demos in follow-up PRs (trying to avoid merge conflicts) |
src/lib/card/card.ts
Outdated
| host: { | ||
| '[class.mat-card-image]': 'true' | ||
| } | ||
| selector: '[md-card-lg-image], [mat-card-lg-image], [mdCarDImageLarge], [matCardImageLarge]', |
There was a problem hiding this comment.
Typo here? Should be mdCardImageLarge
| @@ -43,9 +42,7 @@ export class MdDialogTitle { } | |||
| */ | |||
| @Directive({ | |||
| selector: '[md-dialog-content], md-dialog-content, [mat-dialog-content], mat-dialog-content', | |||
There was a problem hiding this comment.
Should [md-dialog-content] be updated to camelcase too?
| @Input() | ||
| get mdAutosizeMinRows(): number { return this.minRows; } | ||
| set mdAutosizeMinRows(value: number) { this.minRows = value; } | ||
| @Input('matAutosizeMaxRows') |
There was a problem hiding this comment.
This is now private but relied on in internal tests. Do you want to make it deprecated for use and then make private after that?
|
@jelbourn Rebase? |
jelbourn
force-pushed
the
consistent-apis
branch
from
27edb98
to
cec97cf
Compare
|
Done |
jelbourn
added
action: merge
kara
added
the
presubmit failures
jelbourn
force-pushed
the
consistent-apis
branch
from
cec97cf
to
b3ed5aa
Compare
kara
removed
the
presubmit failures
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
trueclass bindings once and for all.md-tab-nav-barto justmdTabNavmd-card-sm-imagetomdCardImageSmall)cc @andrewseguin @kara @mmalerba @tinayuangao for discussion before I do the tests/demos
After this, all of the dash-case selectors would be announced as deprecated in the changelog and removed once I can get them all out of Google apps