fix(slide-toggle): visual hidden input should not bubble click #672
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
* Currently the (click) event gets called twice. This is caused by the bubbling of the (click) event on the input. Fixes angular#671.
googlebot
added
the
cla: yes
* Moved input click event into component source file. * Added comment for the issue cause.
|
@jelbourn Updated the PR (added a comment and moved the event into the component source) |
| // root container, the click event on the `checkbox` will be executed twice. | ||
| // The real click event will bubble up, and the generated click event also tries to bubble up. | ||
| // This will lead to multiple click events. | ||
| // Preventing bubbling for the second event will solve that issue. |
|
LGTM |
This was referenced Jun 15, 2016
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is caused by the bubbling of the (click) event on the input.
Actually the second click will be called by the label element.
The browsers default behavior is, to trigger a click on the input, once the label got clicked.
This is in my opinion the correct approach, because we don't want to depend on the
clickevent, instead of thechangeevent.Fixes #671.