Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(datepicker): keyboard fixes (enter matches click behavior & corre… #7370

Merged
merged 2 commits into from
Dec 5, 2017

Conversation

mmalerba
Copy link
Contributor

@mmalerba mmalerba commented Sep 27, 2017

…ct up and down arrow behavior in year mode).

fixes #7142

@mmalerba mmalerba added Accessibility This issue is related to accessibility (a11y) pr: needs review labels Sep 27, 2017
@mmalerba mmalerba requested a review from jelbourn September 27, 2017 20:48
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Sep 27, 2017
@willshowell
Copy link
Contributor

Does this fix #7142?

@@ -287,6 +287,7 @@ export class MdCalendar<D> implements AfterContentInit, OnDestroy {
case ENTER:
if (this._dateFilterForViews(this._activeDate)) {
this._dateSelected(this._activeDate);
this._userSelected();
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Add test?

@mmalerba mmalerba force-pushed the dp-key branch 2 times, most recently from 0e248c4 to d03a553 Compare October 2, 2017 18:49
@mmalerba
Copy link
Contributor Author

mmalerba commented Oct 2, 2017

fixed existing tests and added test for new behavior

@jelbourn jelbourn added pr: lgtm action: merge The PR is ready for merge by the caretaker and removed pr: needs review labels Oct 27, 2017
@mmalerba mmalerba added this to the 5.0 milestone Nov 20, 2017
@tinayuangao
Copy link
Contributor

@mmalerba please rebase. Thanks!

@mmalerba mmalerba merged commit 0b2757c into angular:master Dec 5, 2017
@mmalerba mmalerba deleted the dp-key branch July 31, 2018 21:56
@angular-automatic-lock-bot
Copy link

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 9, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Accessibility This issue is related to accessibility (a11y) action: merge The PR is ready for merge by the caretaker cla: yes PR author has agreed to Google's Contributor License Agreement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Datepicker - close calendar after selecting date using keyboard
5 participants