-
Notifications
You must be signed in to change notification settings - Fork 6.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Table] Does not work when targetting ES6 #9329
Comments
Same issue |
Looks like this is an issue in the Angular compiler. The |
This should have a higher priority... |
also relate to #9813 |
Looks like the fix has been made in Angular |
Have the same error with angular 5.2.9 and material 5.2.4. |
@Markus-Ende Confirmed that this issue is still present in v5 and v6 :( |
Cool bug - we are using Angular's I'm updating the compiler-cli to the version that will support this: angular/angular#23531 In the meantime, I'm going to create a pull request that forces this to be fixed in our code. Thanks for reporting that the issue is still here. Turns out the other PR was something of a coincidence |
Re-opening, looks like the issue is occurring on the row defs as well |
the issue is occurring on the mat tree too |
Has this issue been fixed for MatRowDefs? We are currently getting what seems to be the same bug, and have updated to the most recent version of Material Error context: ERROR TypeError: Cannot read property 'find' of undefined Angular CLI: 6.0.8 Package Version@angular-devkit/architect 0.6.8 Browser: Chrome |
@WilliamCrossSkymantics you need to revert angular material to 6.4.1 to mitigate the issue. |
Excellent, that fixed the issue. Thanks @Lukespacewalker! |
I am also facing the same issue while using material table in my project, here is the error message,
Development Environment: Angular CLI: 6.1.3 Package Version: Browser : Chrome and Firefox |
@AnilGoudar |
Fixes that the table does not render properly when used inside of a ES2015 application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 Fixes angular#9329
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: angular#12760 Fixes angular#9329.
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: #12760 Fixes #9329.
In the beginning i got the same errors as OP so i downgraded my @angular/material to 6.4.1 which needed @angular/cdk to be 6.4.1 too, so i did that. The errors where gone but now i get this error: this seems so random, like Angular always wants to find a new error :( |
i ran the following command which worked: ng serve --aot --port 1234 |
Fixes that some components does not render properly when used inside of a ES2015 JIT application. This is due to an ongoing Angular issue which has been caused due to a brittle Regex check [introduced here](angular/angular#22356 (comment)) that should be replaced with a more clean approach for identifying classes that inherit metadata from another class. * angular/angular#22642 * angular/tsickle#760 See the more detailed issue here: #12760 Fixes #9329.
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Bug, feature request, or proposal:
Bug
What is the expected behavior?
Table appears in browser.
What is the current behavior?
Table doesn't appear. Error message in console:
What are the steps to reproduce?
Create a new angular 5 project. Add the example code from material.angular.io for mat-table.
It should run fine.
Now go into tsconfig.json and target something higher than es5. Boom.
What is the use-case or motivation for changing an existing behavior?
Projects targeting > es5.
Which versions of Angular, Material, OS, TypeScript, browsers are affected?
Angular 5+, Material 5-rc0 - 5.0.4, TS 2.4.2
Windows 7 64bit
Chrome
The text was updated successfully, but these errors were encountered: