Skip to content
This repository has been archived by the owner on Mar 20, 2024. It is now read-only.

Flattened module structure broke imports on projects that don't contain Angular #79

Closed
4 tasks done
tstirrat15 opened this issue Feb 26, 2018 · 1 comment
Closed
4 tasks done

Comments

@tstirrat15
Copy link

Note: for support questions, please use the Universal Slack Channel or https://gitter.im/angular/universal

  • I'm submitting a ...
  • bug report
  • Which parts of preboot are affected by this issue?
  • server side
  • client side
  • inline
  • Do you want to request a feature or report a bug?

Bug

  • What is the current behavior?
Error: Cannot find module '@angular/core'
    at Function.Module._resolveFilename (module.js:536:15)
    at Function.Module._load (module.js:466:25)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at /usr/src/app/node_modules/preboot/bundles/preboot.umd.js:2:82
    at Object.<anonymous> (/usr/src/app/node_modules/preboot/bundles/preboot.umd.js:5:2)
    at Module._compile (module.js:635:30)
    at Module._compile (/usr/src/app/node_modules/pirates/lib/index.js:91:24)
    at Module._extensions..js (module.js:646:10)
    at Object.newLoader [as .js] (/usr/src/app/node_modules/pirates/lib/index.js:96:7)
    at Module.load (module.js:554:32)
    at tryModuleLoad (module.js:497:12)
    at Function.Module._load (module.js:489:3)
    at Module.require (module.js:579:17)
    at require (internal/module.js:11:18)
    at Object.<anonymous> (/usr/src/app/build/webpack:/external "preboot":1:1)```

It seems that when the structure of the imports was flattened, the imports weren't made... optional? I'm not sure how these sorts of things actually work.

* **If the current behavior is a bug, please provide the steps to reproduce and if possible a minimal demo of the problem** by creating a github repo.

Use preboot in a repo that doesn't contain angular.

* **What is the expected behavior?**

The relevant modules import successfully and the missing peer dependencies are ignored.

* **What is the motivation / use case for changing the behavior?**

See above.

* **Please tell us about your environment:**

- Browser: [all]
- Language: [ ES6/7 | ES5 ]
- OS:  [ Linux ]
- Platform: [NodeJs]

* **Other information** (e.g. detailed explanation, stacktraces, related issues, suggestions how to fix, links for us to have context, eg. stackoverflow, gitter, etc)
@CaerusKaru
Copy link
Member

Duplicate of #80

@CaerusKaru CaerusKaru marked this as a duplicate of #80 Feb 26, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants