You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
{{ message }}
This repository has been archived by the owner on Jul 29, 2024. It is now read-only.
Feature Request
Add logic for handle with modal windows and elements not attached to the DOM.
Add retry logic, for actions with elements, like click, with parameters (how many times and timeout) and/or add some expected condition which will check if element is clickable (expect if other element wouldn’t get click);
Reasons for adopting new feature
Sometimes tests fail because of modal window that appears and disappears (for example after deleting an object). While exists modal window click other element will fail, and we can't handle modal window disappearing moment. The same problem with moving element (with css animation) if we have retry or expected condition it could be resolved. A similar problem with element that not attached to the DOM, from moment of element finding and action.
There’s two ways for resolving this issue
Add some browser.sleep, but if modal window exists time increase it will fail and if sleep time long, test will slow.
Add retry logic, retry(elem.click, howManyTimes, timeout).
Could be cool to have “retry” functionality by default, and one common config for it (by default there could be zero retries there), and may be some custom parameters passed in method: elem.click(howManyTimes, timeout)
Is this a breaking change? (How will this affect existing functionality)
Don't know.
The text was updated successfully, but these errors were encountered:
@sri85 As I see, it uses promise.controlflow, but i'd prefer not to use promise.controlflow (as i know it'll be removed, SeleniumHQ/selenium#2969 ). And I also want it to be out of box, without calling a separate function. I'd like to have one option (use these logic or not, and timeout), if for example i set it to use this logic, it will retry methods implcitly. Example: test try to click button that hidden by a modal window for some time, in this case method click will retry (implicitly) to click for some (preset) time, without calling an external method explicitly.
Feature Request
Add logic for handle with modal windows and elements not attached to the DOM.
Sometimes tests fail because of modal window that appears and disappears (for example after deleting an object). While exists modal window click other element will fail, and we can't handle modal window disappearing moment. The same problem with moving element (with css animation) if we have retry or expected condition it could be resolved. A similar problem with element that not attached to the DOM, from moment of element finding and action.
There’s two ways for resolving this issue
Could be cool to have “retry” functionality by default, and one common config for it (by default there could be zero retries there), and may be some custom parameters passed in method: elem.click(howManyTimes, timeout)
Don't know.
The text was updated successfully, but these errors were encountered: