Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support sourcemaps in TypeScript sources #345

Closed
tbosch opened this issue Jan 26, 2017 · 6 comments
Closed

Support sourcemaps in TypeScript sources #345

tbosch opened this issue Jan 26, 2017 · 6 comments
Assignees
@LucasSloan

Comments

@tbosch
Copy link
Contributor

tbosch commented Jan 26, 2017

The upcoming Angular release will generate sourcemaps from template files into the .ngfactory.ts files. These sourcemaps then need to be combined with other sourcemaps produced by TypeScript, Tsickle, ...
@tbosch
Copy link
Contributor Author

tbosch commented Jan 26, 2017

See angular/angular#14013 for the tracking issue.

Note that this can be implemented in parallel with the issue above.

@tbosch tbosch mentioned this issue Jan 26, 2017
Closed
2 tasks
@mprobst
Copy link
Contributor

mprobst commented Jan 27, 2017

I think this is more of an issue with TypeScript itself, isn't it?

@tbosch
Copy link
Contributor Author

tbosch commented Jan 28, 2017

Yes.
But we need this for Angular 4 and we already have a source-map merging feature in tsickle (using source-map), so adding incoming source maps shouldn't be hard (I talked to @LucasSloan before...). So would be nice to add this as a short term fix...

@mprobst
Copy link
Contributor

mprobst commented Jan 30, 2017 via email

@LucasSloan
Copy link
Contributor

Typescript issue: microsoft/TypeScript#13944

@LucasSloan
Copy link
Contributor

Fixed by #364

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@LucasSloan LucasSloan

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@mprobst @LucasSloan @tbosch