fix(browser/utils): calling removeEventListener twice with the same a…

…rgs should not cause errors Closes #283 Closes #284
angular · Mar 21, 2016 · 1787339 · 1787339
1 parent 4a4d4f6
commit 1787339
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 1 deletion.
diff --git a/lib/browser/utils.ts b/lib/browser/utils.ts
@@ -195,7 +195,7 @@ function zoneAwareRemoveEventListener(self: any, args: any[]) {
   // - When `addEventListener` is called on the global context in strict mode, `this` is undefined
   // see https://github.com/angular/zone.js/issues/190
   var target = self || _global;
-  var eventTask = findExistingRegisteredTask(target, handler, eventName, useCapturing, false);
+  var eventTask = findExistingRegisteredTask(target, handler, eventName, useCapturing, true);
   if (eventTask) {
     eventTask.zone.cancelTask(eventTask);
   } else {

diff --git a/test/browser/element.spec.ts b/test/browser/element.spec.ts
@@ -257,6 +257,13 @@ describe('element', function () {
       button.click();
       expect(log).toEqual('');
     });
+
+    it('should be able to deregister the same event twice', function() {
+      var listener = (event) => {};
+      document.body.addEventListener('click', listener, false);
+      document.body.removeEventListener('click', listener, false);
+      document.body.removeEventListener('click', listener, false);
+    });
   });
 
 });