fix(jasmine): support "pending" it clauses with no test body

Closes #659
angular · Mar 7, 2017 · ddebedd · ddebedd
1 parent bad4ad8
commit ddebedd
Show file tree

Hide file tree

Showing 3 changed files with 7 additions and 4 deletions.
diff --git a/lib/jasmine/jasmine.ts b/lib/jasmine/jasmine.ts
@@ -89,11 +89,11 @@
     // The `done` callback is only passed through if the function expects at least one argument.
     // Note we have to make a function with correct number of arguments, otherwise jasmine will
     // think that all functions are sync or async.
-    return (testBody.length == 0) ? function() {
-      return testProxyZone.run(testBody, this);
-    } : function(done) {
+    return testBody && (testBody.length ? function(done) {
       return testProxyZone.run(testBody, this, [done]);
-    };
+    } : function() {
+      return testProxyZone.run(testBody, this);
+    });
   }
   interface QueueRunner {
     execute(): void;

diff --git a/test/browser_entry_point.ts b/test/browser_entry_point.ts
@@ -22,3 +22,4 @@ import './browser/XMLHttpRequest.spec';
 import './browser/MediaQuery.spec';
 import './mocha-patch.spec';
 import './patch/indexedDB.spec';
+import './jasmine-patch.spec';
diff --git a/test/jasmine-patch.spec.ts b/test/jasmine-patch.spec.ts
@@ -30,6 +30,8 @@ describe('jasmine', () => {
     itZone = Zone.current;
   });
 
+  it('should cope with pending tests, which have no test body');
+
   afterEach(() => {
     let zone = Zone.current;
     expect(zone.name).toEqual('ProxyZone');