Skip to content
This repository has been archived by the owner on Feb 26, 2024. It is now read-only.

fix(core): fix #1108, window.onerror should have (message, source, ....) signiture #1109

Merged
merged 1 commit into from
Jul 17, 2018

Conversation

JiaLiPassion
Copy link
Collaborator

Fix #1108,
Based on the document here, https://developer.mozilla.org/en-US/docs/Web/API/GlobalEventHandlers/onerror#window.onerror

The signature of window.onerror should be

window.onerror = function(message, source, lineno, colno, error) { ... }

And window.addEventListener('error', listener) should be

window.addEventListener('error', function(event) { ... })

So we must handle the onerror special case.

@JiaLiPassion JiaLiPassion force-pushed the onerror branch 6 times, most recently from ced117e to 9529ddf Compare July 5, 2018 16:45
@JiaLiPassion JiaLiPassion changed the title fix(core): fix #1108, window.onerror should have (message, source, ....) signiture WIP(core): fix #1108, window.onerror should have (message, source, ....) signiture Jul 5, 2018
@JiaLiPassion JiaLiPassion force-pushed the onerror branch 5 times, most recently from f85d2fa to 681bbc4 Compare July 6, 2018 12:01
@JiaLiPassion JiaLiPassion changed the title WIP(core): fix #1108, window.onerror should have (message, source, ....) signiture fix(core): fix #1108, window.onerror should have (message, source, ....) signiture Jul 6, 2018
@mhevery mhevery merged commit 49e0548 into angular:master Jul 17, 2018
@pamo
Copy link

pamo commented Oct 31, 2018

Re-iterating what others have already asked: any ideas around when this will be released?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants