Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refactor(ngforms)!: fix all static warnings & rename providers. #54

Merged
merged 3 commits into from
Apr 25, 2023
Merged

refactor(ngforms)!: fix all static warnings & rename providers. #54

merged 3 commits into from
Apr 25, 2023

Conversation

ykmnkmi
Copy link

@ykmnkmi ykmnkmi commented Apr 22, 2023

Renamed providers:

  • FORM_BINDINGS -> formBindings
  • FORM_PROVIDERS -> formProviders
  • NG_VALIDATORS -> ngValidators

@GZGavinZhao GZGavinZhao self-requested a review April 22, 2023 15:06
@GZGavinZhao
test(ngforms): remove unnecessary lint
e599a13 
Signed-off-by: Gavin Zhao <git@gzgz.dev>
GZGavinZhao
GZGavinZhao approved these changes Apr 25, 2023
View reviewed changes
Copy link

@GZGavinZhao GZGavinZhao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. Thanks!

@GZGavinZhao GZGavinZhao merged commit 629c87c into angulardart-community:master Apr 25, 2023
@ykmnkmi ykmnkmi deleted the ngforms_warnings branch April 25, 2023 04:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@GZGavinZhao GZGavinZhao GZGavinZhao approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ykmnkmi @GZGavinZhao