Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Wrong Plural for MeterPerMinute Speed Units Names #1330

Closed
Markussp256 opened this issue Nov 19, 2023 · 2 comments
Closed

Wrong Plural for MeterPerMinute Speed Units Names #1330

Markussp256 opened this issue Nov 19, 2023 · 2 comments
Labels

Comments

@Markussp256
Copy link

Describe the bug
For Speed we have many Units of the form [LengthUnit]Per[TimeUnit]. For instance MeterPerSecond. The plural of it we get by taking the plural of the Lengthunit and the singular of the TimeUnit, for instance MetersPerSecond. However for Units with Meter and Minute also the TimeUnit is currently in Plural form. This makes the method names somehow inconsistent.

Speed has for example the static method FromMetersPerMinutes and FromInchesPerMinute. This also affects all corresponding Units with a prefix, e.g. NanoMetersPerMinutes.

Expected behavior
I would appreciate new methods without the s. The current methods with s should still be usable for a while to not break any code but with a warning that it will be deprecated.

@angularsen
Copy link
Owner

Thanks for reporting, could you please post a list of the units with wrong plural form on #1200 ?

@Markussp256 Markussp256 mentioned this issue Nov 29, 2023
13 tasks
@angularsen
Copy link
Owner

Fixed by #1351 in v6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants