Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Thermal resistance vs resistivity vs insulance #721

Closed
mheyse opened this issue Nov 20, 2019 · 7 comments
Closed

Thermal resistance vs resistivity vs insulance #721

mheyse opened this issue Nov 20, 2019 · 7 comments

Comments

@mheyse
Copy link

mheyse commented Nov 20, 2019

Is your feature request related to a problem? Please describe.
Several different quantities related to heat flow resistance exist. According to Wikipedia (https://en.wikipedia.org/wiki/Thermal_resistance) they are named

  • Thermal resistance [K/W]
  • Thermal resistivity [K·m/W]
  • Thermal insulance [m·m·K/W]

(Not a native English speaker, so I don't know if these terms are really correct).
So according to this Wikipedia article, UnitNet's quantity "ThermalResistance" (unit "m·m·K/W") should actually be named "ThermalInsulance".

My problem is that I want to add a quantity with unit K/W that should be named ThermalResistance according to Wikipedia but this name is already in use by the quantity with unit m·m·K/W.

Describe the solution you'd like
Finding a solution for naming the three quantities listed above. I think the cleanest solution would be renaming ThermalResistance to ThermalInsulance and adding the others but I guess this would be difficult as it breaks backwards compatibility.

@angularsen
Copy link
Owner

Thanks for reporting and describing so well.
I don't know this domain well myself, the ThermalResistance was added by @Hareeshs in 2017. Maybe he could comment on this?

Assuming you are correct about this, there are two ways I see:

  1. Make a breaking change and rename it by adding a pull request to release/v5 branch. There is no ETA on that release yet, but we did want to get it out sometime soon ™️. Currently waiting on completing work around the new UnitSystem design. v5 Roadmap #563
  2. Add a copy of ThermalResistance, name it ThermalInsulance and mark the old one as [Obsolete] with a text explaining to use the new one. Add ThermalResistance2 or a similar placeholder name, that we will rename in v5. At least it can be used until then.

@stale
Copy link

stale bot commented Jan 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Jan 21, 2020
@angularsen
Copy link
Owner

@mheyse Do you have any comments on my suggestions? Are you still interested in pursuing this and making a PR?

@stale stale bot removed the wontfix label Jan 21, 2020
@stale
Copy link

stale bot commented Mar 21, 2020

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Mar 21, 2020
@stale stale bot closed this as completed Mar 29, 2020
@ikijano
Copy link
Contributor

ikijano commented Mar 6, 2022

I like to open this again as ThermalResistance base unit should be K/W instead of m2⋅K/W which is unit of Thermal insulance.
How could I can help with this? Definitely it would be braking change.

Personally have also needs for SpecificThermalResistance (K⋅m/W). I'm working with project where borehole equivalent thermal resistance (which have unit K⋅m/W) calculation is needed and I like to use UnitsNet in there.

@angularsen
Copy link
Owner

Hi, we have a v5 branch going on #982 .

Since it is a breaking change, I propose you make a pull request to that v5 branch instead, then when it's ready and done we can mark things as obsolete in v4. You can then use the prerelease nuget until v5 is fully merged, which is likely to take some time due to low momentum.

@angularsen angularsen reopened this Mar 6, 2022
@stale stale bot removed the wontfix label Mar 6, 2022
@stale
Copy link

stale bot commented Aug 13, 2022

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the wontfix label Aug 13, 2022
@stale stale bot closed this as completed Sep 21, 2022
@lipchev lipchev mentioned this issue Sep 24, 2024
9 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants