Migrate from Travis CI to GitHub Action #1273
Conversation
|
Thanks for the PR @Dinesh101041. I've been in a short time schedule lately, but I should be able to review your lovey PR in the next few days. Sorry for taking so much time. |
| @@ -0,0 +1,36 @@ | |||
| # This is a basic workflow to help you get started with Actions | |||
|
|
|||
| name: CI | |||
There was a problem hiding this comment.
This job won't do anything. What's the meaning of having it? 🤔
| # Run Linter against code base # | ||
| ################################ | ||
| - name: Lint Code Base | ||
| uses: github/super-linter@v3 |
There was a problem hiding this comment.
I didn't know this linter but I had a quick look and we might be better with a simple eslinter setup. I can add eslinter and prettier so you can update this to a simple npm package script. What do you think?
| - run: npm run docs | ||
| - run: npm run build --if-present |
There was a problem hiding this comment.
Will this add the compiled files to the current PR? Else, what's the end result?
There was a problem hiding this comment.
sorry for late reply i am not well in github actions i done this on reading github node workflow doc
here is link of two docs Github node workflow
i will delete the linter and css workflow we can add the eslinter setup
There was a problem hiding this comment.
Any updates on this?
can you please elaborate the conflict and i will delete this pull and make a new pull with all update
There was a problem hiding this comment.
Any updates on this?
can you please elaborate the conflict and i will delete this pull and make a new pull with all update
@eltonmesquita can you please elaborate on it?
|
I think this PR has some conflicts... can you update this @Dinesh101041? |
|
Hi @Dinesh101041 any update on this? cc: @eltonmesquita just checking things here. |
not able to work after that due to other works |
|
I'll close this one as it's outdated by now. I'll take some time and do it myself as it's a task that involves a few other ones. |
Migrate from Travis CI to GitHub Action
Deleted Travis.yml workflow
Fix #1221