-
Notifications
You must be signed in to change notification settings - Fork 16.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename delay classes (Improvement) #1507
Comments
hey there, good suggestion, but it would make animate.css bloated with bunch of specific multiplier. You can always change the default to your liking. What do you think @eltonmesquita? |
@warengonzaga I mean, the classes should just be renamed and not something added. Instead of an "s" (for seconds) just use a "x" for times. "animate__delay-2s" -> sounds like "delay for 2 seconds" |
that's totally make sense! Let me take this... |
@scrobbleme done, PR #1508 🤝 |
This seems a sensible change, I like it. As this is a breaking change, we should ship it with |
Problem
The classes for delaying are currently called
animate__delay-2s, animate__delay-3s, ...
Which also implies that it is always "seconds", which basically is wrong and confusing, as it is a multiplier for a variable delay parameter.
Improvement
The classes should be named i.e.
animate__delay-2x, animate__delay-3x, ...
to better reflect, that they just delay for a specific multiplier.The text was updated successfully, but these errors were encountered: