-
Notifications
You must be signed in to change notification settings - Fork 93
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Research: Refactor useState() hooks to useReducer() #217
Comments
Can I help to solve this issue? |
@HarshKumarChoudary Are you assigned to any other issue currently. If not then I can assign you here. |
I had been assigned one task for which I had made a PR which is Ready to merge. |
Great assigned you here then |
I want to know where we have to describe the solution, in code area or make a new file for it |
I guess this is a research-based issue you just have to suggest benefits/disadvantages here in the comments maybe. |
You dint have to code it right away, this is more of a research type issue. See if you can answer these questions.
|
@HarshKumarChoudary You can also create a doc file describing the solution. You can answer the questions by @jalajcodes in the doc as well. |
I agree with @Rahulm2310, creating it on a doc file will means more than one contributors can propose a suggestion and the PR which solution is approved can be merged and later located easily in the repo when we're ready to implement it. |
ok |
I am ready with the doc. I have to attach that file here in comment or should merge in forked branch and create a PR? |
@HarshKumarChoudary I think you can create a PR with branch called |
I agree with what @Rahulm2310 has suggested. |
Hi @mtreacy002 @Rahulm2310 , can you assign this issue to me also ? :-) |
Hello @naveen8801, thanks for showing interest. Actually, @HarshKumarChoudary has researched on this and submitted a google doc with his findings which you can find in our github wiki here. This doc is open for all so feel free to add your findings to this doc so that everything related to this remains at one place. 🙂 |
Closing this issue as @HarshKumarChoudary had proposed the suggested solution [here]#225) |
Is your feature request related to a problem? Please describe.
Currently we have a lot of separate useState() hooks in each component which makes them less maintainable. The idea is to refactor all the useState() hooks to a useReducer() hook.
Describe the solution you'd like
Research about it. Discuss benefits/disadvantages, and if to be implemented, when is the best timing for refactoring to happen.
Describe alternatives you've considered
NA
Additional context
NA
The text was updated successfully, but these errors were encountered: