Use jetpack navigation for BottomNavigationView #1140
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
BottomNavigationView
(replaces Fragment transactions)main_navigation.xml
navController
to automatically update title according to the label specified in the navigation graph (also can automatically handle back button in the toolbar depending on top-level or sub-level in graph - applicable when we convert more of the activities like Filter, Settings into fragments)SettingsActivity
.Fixes #1088 (Partially, as discussed)
Type of Change:
Code/Quality Assurance Only
How Has This Been Tested?
Tested locally on devices running Android 10 and Android 11.
screen-20210531-133615_1.mp4
Checklist:
Code/Quality Assurance Only