Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use jetpack navigation for BottomNavigationView #1140

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

unc0ded
Copy link
Contributor

@unc0ded unc0ded commented May 31, 2021

Description

  • Added basic navigation component support for BottomNavigationView (replaces Fragment transactions)
    • Added navigation graph main_navigation.xml
    • Set up toolbar (and CollapsingToolbarLayout) with navController to automatically update title according to the label specified in the navigation graph (also can automatically handle back button in the toolbar depending on top-level or sub-level in graph - applicable when we convert more of the activities like Filter, Settings into fragments)
    • Also handles the intent to SettingsActivity.
    • Requires dependencies on navigation component and the safe args plugin for passing data across fragments and activities with type-safety.

Fixes #1088 (Partially, as discussed)

Type of Change:

  • Code

Code/Quality Assurance Only

  • New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Tested locally on devices running Android 10 and Android 11.

screen-20210531-133615_1.mp4

Checklist:

  • My PR follows the style guidelines of this project
  • I have performed a self-review of my own code or materials
  • I have commented my code or provided relevant documentation, particularly in hard-to-understand areas

Code/Quality Assurance Only

  • My changes generate no new warnings
  • My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • Any dependent changes have been published in downstream modules

@unc0ded unc0ded requested a review from isabelcosta as a code owner May 31, 2021 08:12
Copy link
Member

@epicadk epicadk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks looks good

@epicadk epicadk added the Status: Needs Review PR needs an additional review or a maintainer's review. label Jun 1, 2021
@epicadk epicadk self-assigned this Jun 10, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Status: Needs Review PR needs an additional review or a maintainer's review.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature: Use jetpack navigation component
2 participants