Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Bug : Race conditions in register endpoint. #1019

Open
epicadk opened this issue Feb 25, 2021 · 2 comments · May be fixed by #1023
Open

Bug : Race conditions in register endpoint. #1019

epicadk opened this issue Feb 25, 2021 · 2 comments · May be fixed by #1023
Assignees
@epicadk
Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes.

Comments

@epicadk
Copy link
Member

epicadk commented Feb 25, 2021 •
edited
Loading

Describe the bug

If two users send requests to the register endpoint at the same time and both have the same username/emailID then the backend will crash.

To Reproduce
Kind of hard to do this however it can be done programmatically as explained here

Expected behavior

The app should not crash and instead return an error saying that the username is already taken to one of the users and register the other successfully.
@epicadk epicadk added Status: Available Issue was approved and available to claim or abandoned for over 3 days. Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes. labels Feb 25, 2021
@epicadk
Copy link
Member Author

epicadk commented Feb 26, 2021 •
edited
Loading

Can I work on this issue?

@vj-codes
Copy link
Member

Assigning you @epicadk
Happy coding!

@vj-codes vj-codes removed the Status: Available Issue was approved and available to claim or abandoned for over 3 days. label Feb 28, 2021
This was referenced Mar 1, 2021
Open
Open
@gaurivn gaurivn modified the milestone: 1st MVP Jun 12, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@epicadk epicadk

Labels
Category: Coding Changes to code base or refactored code that doesn't fix a bug. Type: Bug Bug or Bug fixes.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fixed race conditions in the signup page epicadk/mentorship-backend
3 participants
@gaurivn @epicadk @vj-codes