feat : Add docker-compose.yml #1043

epicadk · 2021-03-10T16:25:41Z

Description

Create docker-compose.yml and added postgresql as a service so that tests will now run on postgresql and not sqllite

Fixes #1041

Type of Change:

Code
Quality Assurance
Documentation

Code/Quality Assurance Only

This change requires a documentation update (software upgrade on readme file)
New feature (non-breaking change which adds functionality pre-approved by mentors)

How Has This Been Tested?

Ran the commands locally on windows 10

Checklist:

My PR follows the style guidelines of this project
I have performed a self-review of my own code or materials
I have commented my code or provided relevant documentation, particularly in hard-to-understand areas
I have made corresponding changes to the documentation
Any dependent changes have been merged
Update Postman API at /docs folder
Update Swagger documentation and the exported file at /docs folder
Update requirements.txt

Code/Quality Assurance Only

My changes generate no new warnings
My PR currently breaks something (fix or feature that would cause existing functionality to not work as expected)
I have added tests that prove my fix is effective or that my feature works
New and existing unit tests pass locally with my changes
Any dependent changes have been published in downstream modules

epicadk · 2021-03-10T18:53:47Z

@isabelcosta should I also change github actions tests to run on docker?

isabelcosta · 2021-03-10T21:57:01Z

is that a good practice? @epicadk is that the reasoning?

epicadk · 2021-03-11T04:41:52Z

is that a good practice? @epicadk is that the reasoning?

Haha yes it solves the problem of testing the same application you ship : ).

vj-codes · 2021-03-13T08:23:02Z

@epicadk the build is failing , can you look into that please?

epicadk · 2021-03-13T09:54:19Z

@epicadk the build is failing , can you look into that please?

Yes it's because the tests are failing. I'll have to change the github actions or add some env variables, which we can discuss in the next open session.

epicadk · 2021-03-29T05:31:41Z

Still trying to figure out the coverage.

codecov · 2021-04-15T13:31:06Z

Codecov Report

Merging #1043 (b22c754) into develop (8924616) will decrease coverage by 2.22%.
The diff coverage is 100.00%.

❗ Current head b22c754 differs from pull request most recent head d75b8b8. Consider uploading reports for the commit d75b8b8 to get more accurate results

@@             Coverage Diff             @@
##           develop    #1043      +/-   ##
===========================================
- Coverage    94.94%   92.72%   -2.23%     
===========================================
  Files           38       38              
  Lines         2058     2021      -37     
===========================================
- Hits          1954     1874      -80     
- Misses         104      147      +43

Impacted Files	Coverage Δ
config.py	`89.55% <100.00%> (+0.32%)`	⬆️
app/api/dao/user.py	`85.77% <0.00%> (-14.23%)`	⬇️
app/api/dao/mentorship_relation.py	`96.11% <0.00%> (-3.89%)`	⬇️
app/database/db_types/JsonCustomType.py	`73.33% <0.00%> (-3.14%)`	⬇️
app/api/resources/mentorship_relation.py	`96.29% <0.00%> (-0.78%)`	⬇️
app/api/resources/user.py	`89.75% <0.00%> (-0.62%)`	⬇️
app/api/resources/admin.py	`88.13% <0.00%> (-0.58%)`	⬇️
app/database/models/task_comment.py	`95.00% <0.00%> (-0.46%)`	⬇️
run.py	`96.00% <0.00%> (-0.16%)`	⬇️
app/api/dao/admin.py	`95.91% <0.00%> (-0.09%)`	⬇️
... and 13 more

…p-backend into docker-compose

isabelcosta · 2021-04-17T14:14:12Z

Makefile

+
+
+
+
+


only 1 line in the end right 😅

Makefile

config.py

devkapilbansal

@epicadk why we need to run tests using docker? Is there any specific reason to do so?
I have some more questions below

Dockerfile

config.py

docker-compose.test.yml

epicadk · 2021-05-05T19:55:13Z

@epicadk why we need to run tests using docker? Is there any specific reason to do so?
I have some more questions below

Because we want to run the tests on postgres. Made the requested changes.

feat : Add docker-compose.yml

cf21c54

Update main.yml

131f010

epicadk and others added 3 commits April 15, 2021 10:36

minor fix

8167375

Update main.yml

f9baf2f

Merge branch 'develop' into docker-compose

591ade0

epicadk force-pushed the docker-compose branch 2 times, most recently from 50207a1 to 591ade0 Compare April 15, 2021 07:18

epicadk added 6 commits April 15, 2021 12:51

test

485f86c

test

3c40acd

test

4da0068

test

b663eeb

test

a9bd956

test

0cd24e4

epicadk force-pushed the docker-compose branch from c649dcf to c7258d6 Compare April 15, 2021 11:51

Update main.yml

8f71e4f

epicadk force-pushed the docker-compose branch from c7258d6 to 8f71e4f Compare April 15, 2021 11:52

epicadk and others added 4 commits April 15, 2021 17:32

pipe

9df5829

volume

4732e6f

Update main.yml

fcc4ae1

Update main.yml

37c1627

epicadk added 2 commits April 15, 2021 19:13

improve performance

df3ee41

Merge branch 'docker-compose' of https://github.com/epicadk/mentorshi…

7694e7a

…p-backend into docker-compose

epicadk marked this pull request as ready for review April 15, 2021 13:45

Update Makefile

1741ac1

isabelcosta added Status: Changes Requested Changes are required to be done by the PR author. Status: Needs Review PR needs an additional review or a maintainer's review. and removed Status: Changes Requested Changes are required to be done by the PR author. labels Apr 17, 2021

isabelcosta requested review from isabelcosta and devkapilbansal April 17, 2021 13:53

isabelcosta reviewed Apr 17, 2021

View reviewed changes

Makefile Outdated

Comment on lines 16 to 20

Copy link

Member

isabelcosta Apr 17, 2021

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

only 1 line in the end right 😅

devkapilbansal reacted with thumbs up emoji

isabelcosta reviewed Apr 17, 2021

View reviewed changes

Makefile Show resolved Hide resolved

isabelcosta reviewed Apr 17, 2021

View reviewed changes

config.py Show resolved Hide resolved

devkapilbansal suggested changes May 5, 2021

View reviewed changes

Dockerfile Outdated Show resolved Hide resolved

config.py Show resolved Hide resolved

docker-compose.test.yml Outdated Show resolved Hide resolved

devkapilbansal added Status: Changes Requested Changes are required to be done by the PR author. and removed Status: Needs Review PR needs an additional review or a maintainer's review. labels May 5, 2021

epicadk added 3 commits May 6, 2021 01:13

Update Dockerfile

c4bc447

Update docker-compose.test.yml

ada126c

Update Makefile

de1f024

epicadk and others added 2 commits May 6, 2021 01:25

Merge branch 'develop' into docker-compose

b22c754

Merge branch 'develop' into docker-compose

d75b8b8

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat : Add docker-compose.yml #1043

feat : Add docker-compose.yml #1043

epicadk commented Mar 10, 2021

epicadk commented Mar 10, 2021

isabelcosta commented Mar 10, 2021

epicadk commented Mar 11, 2021

vj-codes commented Mar 13, 2021

epicadk commented Mar 13, 2021

epicadk commented Mar 29, 2021

codecov bot commented Apr 15, 2021 •

edited

Loading

isabelcosta Apr 17, 2021

devkapilbansal left a comment

epicadk commented May 5, 2021

feat : Add docker-compose.yml #1043

Are you sure you want to change the base?

feat : Add docker-compose.yml #1043

Conversation

epicadk commented Mar 10, 2021

Description

Type of Change:

How Has This Been Tested?

Checklist:

epicadk commented Mar 10, 2021

isabelcosta commented Mar 10, 2021

epicadk commented Mar 11, 2021

vj-codes commented Mar 13, 2021

epicadk commented Mar 13, 2021

epicadk commented Mar 29, 2021

codecov bot commented Apr 15, 2021 • edited Loading

Codecov Report

isabelcosta Apr 17, 2021

Choose a reason for hiding this comment

devkapilbansal left a comment

Choose a reason for hiding this comment

epicadk commented May 5, 2021

codecov bot commented Apr 15, 2021 •

edited

Loading